Self-Test: Ignore width space after em dash #654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AsciiDoctor spits out an em dash when there is an em dash between two words. This is kind of a pleasant surprise because it makes it clear that we can break words after the em dash. This change teaches the `html_diff` utility that we use for finding differences in pages that this particular zero width space doesn't count as a difference.
|
Bleh merge conflict with myself! |
|
Conflict resolved! |
|
@Jarpy, could you have a look at this one when you get a chance please? |
ghost
approved these changes
Mar 7, 2019
I signed up for it! Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AsciiDoctor spits out an em dash when there is an em dash between two
words. This is kind of a pleasant surprise because it makes it clear
that we can break words after the em dash. This change teaches the
html_diffutility that we use for finding differences in pages thatthis particular zero width space doesn't count as a difference.